Vite compatible #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

curran merged 2 commits into main from vite-compatible

Mar 6, 2023

Collaborator

curran commented Mar 6, 2023 •

edited

Loading

Makes the build compatible with Vite by:

Using the .cjs extension
Not exporting JSON1 at the top level, because it doesn't work for some reason (potentially to do with the __esModule field)

The consuming project needs to put the following in the Vite config:

  // Required to have Vite properly handle these CommonJS imports
  optimizeDeps: {
    include: [
      'sharedb-client-browser/dist/sharedb-client-umd.cjs',
      'sharedb-client-browser/dist/ot-json1-presence-umd.cjs'
    ]
  },

curran added 2 commits

March 4, 2023 07:00


          3.0.2

82a5b5a


          Make build compatible with Vite

2239deb

curran mentioned this pull request

Presence cursors vizhub-core/vzcode#16

Closed

curran merged commit dd9afb2 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet