Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android crash at imagePolyfill #48

Merged
merged 1 commit into from
Apr 4, 2020
Merged

fix: android crash at imagePolyfill #48

merged 1 commit into from
Apr 4, 2020

Conversation

rnike
Copy link
Collaborator

@rnike rnike commented Apr 3, 2020 •
edited
Loading

Hi, sorry for the error, the reason is there is no prefetch method in animatableImage. I think it's better to use AnimatableImage instead of just Image to avoid errors like this in the future.

@rnike rnike mentioned this pull request Apr 3, 2020
Closed
ngregrichardson
ngregrichardson approved these changes Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@ngregrichardson ngregrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me, I was looking into similar changes

@vivaxy vivaxy merged commit 9a784fe into vivaxy:master Apr 4, 2020
@vivaxy
Copy link
Owner

vivaxy commented Apr 4, 2020

Thank you @yum650350 @ngregrichardson 1

@rnike rnike deleted the fix/android-crash branch April 4, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngregrichardson ngregrichardson ngregrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnike @vivaxy @ngregrichardson