Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Update parse.ts #9

Merged
merged 1 commit into from
May 5, 2020
Merged

Update parse.ts #9

merged 1 commit into from
May 5, 2020

Conversation

ofzo
Copy link
Contributor

@ofzo ofzo commented May 5, 2020

移除右闭合标签的无子节点检查

移除右闭合标签的无子节点检查
@vivaxy
Copy link
Owner

vivaxy commented May 5, 2020

为什么要移除检查?请提供用例。

@ofzo
Copy link
Contributor Author

ofzo commented May 5, 2020

@vivaxy
示例:

<navigator class="bottom" url="/pages/user-login/user-login" bind:tap="raceLogin">
        <primary-button>立即体验</primary-button>
    </navigator>

navigator 闭合时, 会出现遗留的primary-button节点, 导致解析错误

示例错误堆栈:

/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse.js:72
    throw new Error(message)
    ^

Error: Unexpected node{"type":1,"tagName":"primary-button","attributes":{},"selfClosing":false,"childNodes":[{"type":3,"textContent":"立即体验"}]}
    at throwError (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse.js:72:11)
    at ensureNoNode (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse.js:76:7)
    at 3 (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse.js:41:9)
    at traverse (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse.js:69:5)
    at 2 (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse/tokenize.js:205:9)
    at Object.tokenize [as default] (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse/tokenize.js:345:7)
    at Object.parse (/Users/roadup/Work/mini-app/packages/complier/node_modules/@vivaxy/wxml/lib/lib/parse.js:84:21)
    at Object.<anonymous> (/Users/roadup/Work/mini-app/packages/complier/src/complierWxml.js:10:18)
    at Module._compile (internal/modules/cjs/loader.js:1151:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1171:10)

事实上不太明白为何要做这个检查

@vivaxy vivaxy closed this May 5, 2020
@vivaxy vivaxy reopened this May 5, 2020
@vivaxy vivaxy merged commit e5bb386 into vivaxy:master May 5, 2020
@vivaxy
Copy link
Owner

vivaxy commented May 5, 2020

感谢指正~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants