Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable isolatedDeclarations #7473

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Feb 12, 2025

Description

Enable isolatedDeclarations for all packages except ui/client

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 995772c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67ae121f0553ae00085cf20c
😎 Deploy Preview https://deploy-preview-7473--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sxzz
Copy link
Contributor Author

sxzz commented Feb 12, 2025

All tests are passed, PTAL /cc @sheremet-va

@sxzz sxzz force-pushed the refactor/isolated-decl branch from 7ce12dc to 66b5a37 Compare February 12, 2025 12:19
@sxzz
Copy link
Contributor Author

sxzz commented Feb 12, 2025

All change requests have been applied. Thank you for your thorough review. Some parts were completed by the TS language server.

sheremet-va
sheremet-va previously approved these changes Feb 12, 2025
hi-ogawa
hi-ogawa previously approved these changes Feb 13, 2025
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can't wait for the faster build 😃

@sxzz
Copy link
Contributor Author

sxzz commented Feb 13, 2025

Let's merge this PR first, then #7473 (there are still some issues to resolve in #7423).

AriPerkkio
AriPerkkio previously approved these changes Feb 13, 2025
@sheremet-va sheremet-va dismissed stale reviews from AriPerkkio, hi-ogawa, and themself via 083abc6 February 13, 2025 15:17
@sheremet-va sheremet-va enabled auto-merge (squash) February 13, 2025 15:17
@sheremet-va sheremet-va disabled auto-merge February 13, 2025 15:17
@sheremet-va sheremet-va enabled auto-merge (squash) February 13, 2025 15:17
@sheremet-va sheremet-va merged commit accd2ed into vitest-dev:main Feb 13, 2025
13 checks passed
@sxzz sxzz deleted the refactor/isolated-decl branch February 16, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants