Add docs for cycle detection in foreign keys #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
shlomi-noach
approved these changes
Mar 14, 2024
| `id` bigint unsigned NOT NULL AUTO_INCREMENT, | ||
| `manager_id` bigint unsigned NOT NULL, | ||
| PRIMARY KEY (`id`), | ||
| UNIQUE KEY `idx_manager_id` (`manager_id`), |
There was a problem hiding this comment.
Nit, but make this a KEY rather than UNIQUE KEY. It wouldn't make sense to have UNIQUE in this model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the docs for vitessio/vitess#15458