Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdbc: bump dep versions in order to pull in grpc 1.5.0 -> 1.11.0 #3891

Merged
merged 1 commit into from
May 12, 2018
Merged

jdbc: bump dep versions in order to pull in grpc 1.5.0 -> 1.11.0 #3891

merged 1 commit into from
May 12, 2018

Conversation

acharis
Copy link
Contributor

@acharis acharis commented May 3, 2018

we therefore now pull in:

  • guava 19.0 -> 20.0
  • netty-handler 4.1.12.Final -> 4.1.22.Final
  • netty-tcnative-boringssl-static 2.0.3.Final -> 2.0.7.Final

Signed-off-by: Alex Charis [email protected]

jdbc: bump dep versions in order to pull in grpc 1.5.0 -> 1.11.0
325e9ca 
we therefore now pull in:
 - guava 19.0 -> 20.0
 - netty-handler 4.1.12.Final -> 4.1.22.Final
 - netty-tcnative-boringssl-static 2.0.3.Final -> 2.0.7.Final

Signed-off-by: Alex Charis <[email protected]>
michael-berlin
michael-berlin approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@michael-berlin michael-berlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do the Java folks have any concerns here?

@harshit-gangal
Copy link
Member

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@acharis
Copy link
Contributor Author

acharis commented May 4, 2018

I'm still testing this here, but it would be great to get the input from @harshit-gangal at least.
(And I would love to know who else uses the vitess-jdbc driver!)

@acharis
Copy link
Contributor Author

acharis commented May 4, 2018

why do i never reload github pages before commenting

@harshit-gangal
Copy link
Member

harshit-gangal commented May 4, 2018 •
edited
Loading

Is it failing? I see all the checks are passing.

@acharis
Copy link
Contributor Author

acharis commented May 7, 2018

It's not failing. But I'd like to see it tested in action internally before I'm satisfied with it.

@sougou
Copy link
Contributor

sougou commented May 9, 2018

If you're happy with your testing, I can merge this.

@acharis
Copy link
Contributor Author

acharis commented May 12, 2018

We've been running a limited deployment of this internally for five days and it's looking good. We can go ahead and merge if you like, or we can be more conservative about it and wait for a larger rollout. I'm fine with either.

@sougou sougou merged commit 36c044e into vitessio:master May 12, 2018
andyedison pushed a commit to github/vitess-gh that referenced this pull request Jul 29, 2024
@planetscale-actions-bot @GuptaManan100 @andyedison
[latest-17.0](vitessio#3891): CherryPick(vitessio#14716): Fix Registe…
90691fa 
…rNotifier to use a copy of the tables to prevent data races (vitessio#3900)

* backport of 3891

* feat: fix build issues

Signed-off-by: Manan Gupta <[email protected]>

---------

Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-berlin michael-berlin michael-berlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acharis @harshit-gangal @sougou @michael-berlin