-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Disable /debug/vrlog by default #17832
Open
mattlord
wants to merge
6
commits into
vitessio:main
Choose a base branch
from
planetscale:vrlog_flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+47
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Matt Lord <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17832 +/- ##
=======================================
Coverage 67.45% 67.45%
=======================================
Files 1592 1592
Lines 258167 258189 +22
=======================================
+ Hits 174143 174172 +29
+ Misses 84024 84017 -7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matt Lord <[email protected]>
rohit-nayak-ps
approved these changes
Feb 20, 2025
dbussink
approved these changes
Feb 21, 2025
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
/debug/vrlog
tablet HTTP endpoint was added in #5889.That was very helpful in the early development of VReplication. It can still be useful today but its use is quite rare (note that it's not documented today either).
Given that the production of this log is not lightweight, we should disable it by default. That's what this PR does, while adding a flag to enable it for the rare cases that it's wanted. I'll also document the web endpoint along with the new flag.
Related Issue(s)
Checklist