-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear demotePrimaryStalled
field after the function ends
#17823
Merged
GuptaManan100
merged 3 commits into
vitessio:main
from
planetscale:clear-demote-primary-stalled
Feb 21, 2025
Merged
Clear demotePrimaryStalled
field after the function ends
#17823
GuptaManan100
merged 3 commits into
vitessio:main
from
planetscale:clear-demote-primary-stalled
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17823 +/- ##
==========================================
- Coverage 67.44% 67.44% -0.01%
==========================================
Files 1592 1592
Lines 258076 258174 +98
==========================================
+ Hits 174051 174113 +62
- Misses 84025 84061 +36 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
mattlord
approved these changes
Feb 19, 2025
deepthi
reviewed
Feb 19, 2025
timvaillancourt
approved these changes
Feb 19, 2025
Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue pointed out in #17822 by clearing the demote primary stalled field after the function finishes.
Related Issue(s)
demotePrimaryStalled
is set, it is not reset even if DemotePrimary unblocks #17822Checklist
Deployment Notes