Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore execution time errors for schemadiff view analysis #17704

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Feb 5, 2025

The UnsupportedConstruct error is returned for execution of select queries inside vtgate, but when we analyze views we don't care about those.

Views here are executed at the MySQL level though and always inside a single shard, so we don't want to return these errors.

The test example here shows a case where it thinks it's in sharded mode because of a missing dependency, but we only want to show that we're missing a table dependency.

Related Issue(s)

Part of #10203

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

The UnsupportedConstruct error is returned for execution of select
queries inside vtgate, but when we analyze views we don't care about
those.

Views here are executed at the MySQL level though and always inside a
single shard, so we don't want to return these errors.

The test example here shows a case where it thinks it's in sharded mode
because of a missing dependency, but we only want to show that we're
missing a table dependency.

Signed-off-by: Dirkjan Bussink <[email protected]>
Copy link
Contributor

vitess-bot bot commented Feb 5, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 5, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 5, 2025
@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: schema management schemadiff and schema changes and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.80%. Comparing base (71b2cae) to head (10b6758).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17704      +/-   ##
==========================================
+ Coverage   67.77%   67.80%   +0.02%     
==========================================
  Files        1587     1587              
  Lines      255798   255830      +32     
==========================================
+ Hits       173379   173474      +95     
+ Misses      82419    82356      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink merged commit 3669569 into vitessio:main Feb 6, 2025
112 of 115 checks passed
@dbussink dbussink deleted the dbussink/schemadiff-ignore-query-execution branch February 6, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: schema management schemadiff and schema changes Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants