-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic inside schema tracker #17659
Merged
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-schema-tracker-panic
Jan 31, 2025
Merged
Fix panic inside schema tracker #17659
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-schema-tracker-panic
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema tracker was not using strict DDL parsing which means that on an unparsable table definition, it would panic later on. The intent here always was from looking at the code to skip any table that can't be parsed properly, so let's do that here instead. Signed-off-by: Dirkjan Bussink <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
mattlord
approved these changes
Jan 30, 2025
frouioui
approved these changes
Jan 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17659 +/- ##
=======================================
Coverage 67.75% 67.76%
=======================================
Files 1586 1586
Lines 255754 255770 +16
=======================================
+ Hits 173280 173313 +33
+ Misses 82474 82457 -17 ☔ View full report in Codecov by Sentry. |
vitess-bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
dbussink
pushed a commit
that referenced
this pull request
Jan 31, 2025
dbussink
pushed a commit
that referenced
this pull request
Jan 31, 2025
This was referenced Jan 31, 2025
rohit-nayak-ps
pushed a commit
that referenced
this pull request
Feb 1, 2025
Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema tracker was not using strict DDL parsing which means that on an unparsable table definition, it would panic later on.
The intent here always was from looking at the code to skip any table that can't be parsed properly, so let's do that here instead.
Marked for backporting as this can lead to a panic and vtgate being in a crash loop if there's a schema in MySQL that can't be parsed.
Related Issue(s)
Reported here.
Part of fixing #17670
Checklist