Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update the Golang dependencies using a CRON #14891

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Automatically update the Golang dependencies using a CRON #14891

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9457ac
add update go deps workflow
frouioui Jan 4, 2024
015ac9f
change step name
frouioui Jan 4, 2024
dafec29
revert test code
frouioui Jan 4, 2024
5a7d231
do not skip on fork
frouioui Jan 4, 2024
4d1d433
run only on the main branch
frouioui Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/workflows/update_golang_dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: Update Golang Dependencies

on:
schedule:
- cron: "0 0 * * *" # Runs every day at midnight UTC
workflow_dispatch:

permissions: read-all

jobs:
update_golang_deps:
if: github.repository == 'vitessio/vitess'
permissions:
contents: write
pull-requests: write
strategy:
matrix:
branch: [ main, release-18.0, release-17.0, release-16.0 ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only part that I have some reservations/questions about.

name: Update Golang Dependencies
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.21.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we keep this aligned with the go version as we upgrade that pretty regularly, especially on main.

If we do end up doing this on release branches, will this not cause issues when those are using an older version of go than main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automation that bumps the golang version throughout the codebase will keep this aligned for us without having to do anything more.


- name: Check out code
uses: actions/checkout@v3
with:
ref: ${{ matrix.branch }}

- name: Upgrade the Golang Dependencies
id: detect-and-update
run: |
go get -u ./...

output=$(git status -s)
if [ -z "${output}" ]; then
exit 0
fi

go mod tidy

- name: Create Pull Request
uses: peter-evans/create-pull-request@v4
with:
branch: "upgrade-go-deps-on-${{ matrix.branch }}"
commit-message: "upgrade go deps"
signoff: true
delete-branch: true
title: "[${{ matrix.branch }}] Upgrade the Golang Dependencies"
body: |
This Pull Request updates all the Goland dependencies to their latest version using `go get -u ./...`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoot sorry i missed this

s/Goland/Golang

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed with #14896

base: ${{ matrix.branch }}
labels: |
go
dependencies
Component: General
Type: Internal Cleanup