Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTGate/foreign keys stress test: add tests for 'standard' replica #14747

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Dec 11, 2023

Description

#13799 introduced VTGate stress tests for foreign keys, and #14098 further improved them. Among the techniques used, we set up a primary with foreign key tables, and a replica where we stripped out the foreign key constraints. This setup validated that VTGate's cascading of foreign key rules works correctly, by comparing data on primary and replica.

This PR adds an additional replica, this time a standard, "faithful" one. The objective with this replica is to validate that the schema on primary and replica are consistent after Online DDL. This is something we can't do with the already existing replica as we intentionally diverged the schema on that replica in the first place.

The test compares the new, "faithful" replica with the primary, expected identical schema, explicitly makes sure that foreign key referenced tables are pinned to the correct primaries (validating the effects of rename_table_preserve_foreign_key) and of course also validates that the data is identical.

We are modifying the behavior of rename_table_preserve_foreign_key in our public fork. The tests are expected to fail right away and to pass once we've updated the forked MySQL image pass as we're not yet using the forked MySQL image in this repo's CI.

Related Issue(s)

#11975

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Dec 11, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 11, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 11, 2023
@shlomi-noach shlomi-noach added Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 11, 2023
…serve_foreign_key is meaningless

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach requested a review from a team December 21, 2023 06:55
@shlomi-noach
Copy link
Contributor Author

Looking for 2nd review.

@shlomi-noach shlomi-noach merged commit c91f57b into vitessio:main Dec 21, 2023
116 checks passed
@shlomi-noach shlomi-noach deleted the vtgate-fk-stress-replica branch December 21, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants