Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HAVING rewriting made in #11306 #11515

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix HAVING rewriting made in #11306 #11515

merged 3 commits into from
Oct 18, 2022

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 17, 2022 •
edited by systay
Loading

Description

This Pull Request fixes a recent change introduced by #11306. An issue appeared several days ago as described in planetscale/discussion#308. We were rewriting the having expression to whatever was underneath the alias in the select list which is incorrect.

We can only safely do this rewrite when the expression we want to filter by is not using any columns from the tables, so we should check that the predicate doesn't reference any columns that are out of scope.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 17, 2022 •
edited by dbussink
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

systay added 2 commits October 17, 2022 16:35
@systay
don't rewrite HAVING predicates that use table columns
a2a010c 
Signed-off-by: Andres Taylor <[email protected]>
@systay
Revert the changes made in vitessio#11306
44df41b 
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
@systay systay changed the title Revert HAVING rewriting made in #11306 Fix HAVING rewriting made in #11306 Oct 17, 2022
@frouioui
Fix early rewriter test
377f258 
Signed-off-by: Florent Poinsard <[email protected]>
@rsajwani rsajwani mentioned this pull request Oct 18, 2022
Closed
100 tasks
@frouioui frouioui merged commit 83543b8 into vitessio:main Oct 18, 2022
@frouioui frouioui deleted the revert-11306 branch October 18, 2022 06:55
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 18, 2022

I was unable to backport this Pull Request to the following branches: release-15.0.

@frouioui
Copy link
Member Author

Not backporting this as the original Pull Request (#11306) was not backported.

frouioui added a commit to planetscale/vitess that referenced this pull request Oct 18, 2022
@frouioui @systay
Fix HAVING rewriting made in vitessio#11306 (vitessio#11515)
7bb6784 
* don't rewrite HAVING predicates that use table columns

Signed-off-by: Andres Taylor <[email protected]>

* Revert the changes made in vitessio#11306

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>

* Fix early rewriter test

Signed-off-by: Florent Poinsard <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
@frouioui frouioui mentioned this pull request Oct 18, 2022
Merged
@frouioui
Copy link
Member Author

Not backporting this as the original Pull Request (#11306) was not backported.

You can dismiss my comment. The issue lives in release-15.0 too. Backport PR: #11526

frouioui added a commit that referenced this pull request Oct 20, 2022
@frouioui @systay
Fix HAVING rewriting made in #11306 (#11515) (#11526)
4f125f3 
* don't rewrite HAVING predicates that use table columns

Signed-off-by: Andres Taylor <[email protected]>

* Revert the changes made in #11306

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>

* Fix early rewriter test

Signed-off-by: Florent Poinsard <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@frouioui @systay
Fix HAVING rewriting made in vitessio#11306 (vitessio#11515) (vites…
f6a8b2d 
…sio#1163)

* don't rewrite HAVING predicates that use table columns

Signed-off-by: Andres Taylor <[email protected]>

* Revert the changes made in vitessio#11306

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>

* Fix early rewriter test

Signed-off-by: Florent Poinsard <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frouioui @dbussink @systay @deepthi