Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vtadmin build #634

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Skip vtadmin build #634

merged 1 commit into from
Jan 28, 2025

Conversation

frouioui
Copy link
Member

This fixes an issue that was observed after the recent node/vite versions upgrade vitessio/vitess#17606. When building Vitess we were getting an error from npm:

failed to load config from /go/src/vitess.io/vitess/web/vtadmin/vite.config.ts
error during build:
Error: The package "@esbuild/linux-x64" could not be found, and is needed by esbuild.

This issue is fixable by removing the local dependencies (rm -rf node_modules package-lock.json) and re-installing them (npm install).

However, we don't actually need to build vtadmin in arewefastyet so let's skip its build altogether.

Signed-off-by: Florent Poinsard <[email protected]>
@deepthi deepthi merged commit de5bf6a into main Jan 28, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants