Fix performance issue on the status page #522

frouioui · 2024-04-02T20:56:30Z

Fixes #521

[GIN] 2024/04/02 - 14:53:00 | 200 |  788.178958ms |             ::1 | GET      "/api/recent"
[GIN] 2024/04/02 - 14:53:01 | 200 |   94.367042ms |             ::1 | GET      "/api/recent"
[GIN] 2024/04/02 - 14:53:02 | 200 |   93.952292ms |             ::1 | GET      "/api/recent"
[GIN] 2024/04/02 - 14:53:03 | 200 |  182.713041ms |             ::1 | GET      "/api/recent"
[GIN] 2024/04/02 - 14:53:04 | 200 |  179.287459ms |             ::1 | GET      "/api/recent"

Signed-off-by: Florent Poinsard <[email protected]>

frouioui · 2024-04-02T21:17:27Z

go/exec/exec.go

-		if exec.TypeOf != "micro" {
-			macroResult, err := client.Select("SELECT m.vtgate_planner_version FROM macrobenchmark m, execution e WHERE e.uuid = m.exec_uuid AND e.uuid = ? LIMIT 1", eUUID)
-			if err != nil {


We were not even rendering the query planner version on the web page, so it is totally fine to remove these extra db calls.

Fix performance issue on the status page

245d650

Signed-off-by: Florent Poinsard <[email protected]>

frouioui commented Apr 2, 2024

View reviewed changes

frouioui merged commit 222c018 into main Apr 2, 2024
10 of 12 checks passed

frouioui deleted the speedup-status-page branch April 2, 2024 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix performance issue on the status page #522

Fix performance issue on the status page #522

frouioui commented Apr 2, 2024

frouioui Apr 2, 2024

Fix performance issue on the status page #522

Fix performance issue on the status page #522

Conversation

frouioui commented Apr 2, 2024

frouioui Apr 2, 2024

Choose a reason for hiding this comment