chore(deps): update dependency @rollup/plugin-commonjs to v22

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@rollup/plugin-commonjs	^21.1.0 -> ^22.0.0

---

Release Notes

rollup/plugins

v22.0.0

2022-04-24

Breaking Changes

• fix: add heuristic to deoptimize requires after calling imported function (requires [email protected]) (#​1038)
• feat: reimplement dynamic import handling (requires Node 12, no longer supports require.cache) (#​1038)

Bugfixes

• fix: support CJS modules re-exporting transpiled ESM modules (#​1165)
• fix: Warn when plugins do not pass options to resolveId (#​1038)
• fix: Do not change semantics when removing requires in if statements (#​1038)
• fix: handle external dependencies when using the cache (#​1038)
• fix: proxy all entries to not break legacy polyfill plugins (#​1038)
• fix: use correct version and add package exports (#​1038)
• fix: validate node-resolve peer version (#​1038)
• fix: inject module name into dynamic require function (#​1038)
• fix: do not transform "typeof exports" for mixed modules (#​1038)
• fix: attach correct plugin meta-data to commonjs modules (#​1038)

Features

• feat: expose plugin version (#​1038)
• feat: throw for dynamic requires from outside the configured root (#​1038)
• feat: add dynamicRequireRoot option (#​1038)
• feat: auto-detect conditional requires (#​1038)
• feat: limit ignoreTryCatch to external requires (#​1038)
• feat: make namespace callable when requiring ESM with function default (#​1038)
• feat: Infer type for unidentified modules (#​1038)
• feat: automatically wrap cyclic modules (#​1038)
• feat: add strictRequires option to wrap modules (#​1038)

Updates

• refactor: deconflict helpers only once globals are known (#​1038)

---

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by Mend Renovate. View repository job log here.

[fwouts]

This PR should fix #2139.

[fwouts]

I managed to fix the serve tests in https://github.com/fwouts/vite/tree/renovate/rollup-plugin-commonjs-22.x but a lot of build tests are failing. It could be because of rollup/plugins#1169, although I'm not familiar enough with Vite internals to be able to tell.

[NMinhNguyen]

Thanks for your work on this @fwouts. I also raised #7894 because bumping the plugin alone isn't sufficient - we need to bump Rollup too. But I guess you're right in that there's an issue upstream that needs fixing first..

[patak-dev]

I think the change in plugin-commonjs is big enough to push it to the next minor/major. There may be bugs that are going to surface in the next weeks. We're going to start the Vite 3 beta period soon, so let's merge it then.

[patak-dev]

We are no longer going to use @rollup/plugin-commonjs by default in Vite v3. I'll remove the 3.0 milestone from this PR as it is no longer a blocker for v3. But it would still be good to look into what is the problem here and be able to use the latest version for users that can't migrate to the new esbuild-based interop.

[patak-dev]

Actually, closing this one as #7894 is more advanced towards being able to update.

[renovate]

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 22.x releases. However, if you upgrade to 22.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

[dantman]

@patak-dev rollup/plugins#988 is probably the primary reason for some users to want the updated plugin-commonjs. There is a collection of libraries using cyclic requires in ways that the version of plugin-commonjs that Vite is currently using breaks. So those libraries just cannot be used in Vite.

[kskalski]

migrate to the new esbuild-based interop

@patak-dev Any docs on what it will take to do so?

There is a collection of libraries using cyclic requires

Right, which makes me wonder if "esbuild-based interop" will solve that naturally or will it become even farther from being solved by completely eliminating those libraries (in my case pulled as dependency indirectly) from being used in Vite.

[patak-dev]

@dantman @kskalski you can already try esbuild-based interop in [email protected], it is the default at least during the alpha. If there is a bug in esbuild with cyclic requires, then it would be good to report it to esbuild so it is fixed. But IIUC, this wasn't the case. Please report back, there may still be other issues though as this new code path is new and we need to polish it before the stable release.
And about the update to rollup plugin-commonjs v22, check #7894. I closed this issue and removed both from the v3 milestone because looks like it isn't a blocker anymore but we still need to make Vite compatible with it. If someone finds out a way to move #7894, contribution welcome.