Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed empty line after ssr import #7488

Closed
wants to merge 1 commit into from
Closed

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Mar 27, 2022

Description

Original code

import { createRequire as _createRequire } from "module";
const __require = _createRequire(import.meta.url);
const openapi = __require("@nestjs/swagger");
import { PrismaService } from '@bonfire/prisma';
import { Controller, Get } from '@nestjs/common';

Before this fix

const __vite_ssr_import_0__ = await __vite_ssr_import__("module");

const __require = __vite_ssr_import_0__.createRequire(__vite_ssr_import_meta__.url);
const openapi = __require("@nestjs/swagger");
const __vite_ssr_import_1__ = await __vite_ssr_import__("/@fs/home/Gautier/projects/bonfire/packages/prisma/build/index.js");

const __vite_ssr_import_2__ = await __vite_ssr_import__("@nestjs/common");

After this fix

const __vite_ssr_import_0__ = await __vite_ssr_import__("module");
const __require = __vite_ssr_import_0__.createRequire(__vite_ssr_import_meta__.url);
const openapi = __require("@nestjs/swagger");
const __vite_ssr_import_1__ = await __vite_ssr_import__("/@fs/home/Gautier/projects/bonfire/packages/prisma/build/index.js");
const __vite_ssr_import_2__ = await __vite_ssr_import__("@nestjs/common");

Additional context

This is a temporary workaround for #7487


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@GauBen
Copy link
Contributor Author

GauBen commented Mar 27, 2022

Turns out the extra line break is inserted somewhere else...

@GauBen GauBen marked this pull request as draft March 27, 2022 16:30
@patak-dev
Copy link
Member

Thanks for the PR. We'll close it due to inactivity, but please open a new PR if you end up working on this improvement in the future.

@patak-dev patak-dev closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants