Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update react-swc plugin version in create-vite by renovate #19394

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 10, 2025

Description

By using custom manager feature, it should be possible to auto update react-swc plugin version in the source code as well.
https://docs.renovatebot.com/modules/manager/regex/

refs #19384

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Feb 10, 2025
@@ -593,10 +593,13 @@ function pkgFromUserAgent(userAgent: string | undefined): PkgInfo | undefined {
}

function setupReactSwc(root: string, isTs: boolean) {
// renovate: datasource=npm depName=@vitejs/plugin-react-swc
const reactSwcPluginVersion = '3.7.2'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const reactSwcPluginVersion = '3.7.2'
const reactSwcPluginVersion = '3.7.0'

I'm not sure how to test this PR. Maybe setting a lower version so that renovate tries to update it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with not testing this for now. Verifying the regex manually it seems that it should work as expected though.

@sapphi-red sapphi-red merged commit 0f058a9 into vitejs:main Feb 13, 2025
15 checks passed
@sapphi-red sapphi-red deleted the ci/update-react-swc-plugin-version-in-create-vite branch February 13, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants