Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: optimize home page styles #18539

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

warmthsea
Copy link
Contributor

The reasons for the change are as follows (Will not affect other codes):

  • Please expand for before and after comparison
1、Non-dark mode display abnormality

before

image

after

image

html.dark:has(.landing) {
  --vp-c-bg: #101010;
}
2、Switching to the home page, the transition animation of the header is stiff

before

screenshots

after

screenshots

transition: none;

.VPNavBar *:not(.wrapper *) {
  transition: none;
}
3、Appearance Small screen display is meaningless

before

image

after

image

.VPMenu .translations + .group {
  display: none;
}

@bluwy
Copy link
Member

bluwy commented Oct 31, 2024

Amazing PR description!

For no1, I think I've already fixed it at #18281 but it's not reflected on the site yet. It is on https://main.vite.dev though. So maybe we don't need that change here for now.

The rest looks great.

@warmthsea
Copy link
Contributor Author

Amazing PR description!

For no1, I think I've already fixed it at #18281 but it's not reflected on the site yet. It is on https://main.vite.dev though. So maybe we don't need that change here for now.

The rest looks great.

No1
I actually changed the bottom of the search box because it does look a bit weird now.

Ⅰ. before (main.vite.dev)

image

Ⅱ. after (current)

image

Ⅲ. or change the text (If this is the presentation method, I will submit the code)

image

I will delete the code for No1 if it is not needed.

@bluwy
Copy link
Member

bluwy commented Oct 31, 2024

Oh I didn't realize that you're changing the footer part. Nevermind then, let's keep the PR as is 👍

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@patak-dev patak-dev merged commit 887ce8b into vitejs:main Oct 31, 2024
7 of 11 checks passed
@warmthsea warmthsea deleted the docs/home-style branch October 31, 2024 23:52
patak-dev pushed a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants