Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove injectInvalidationTimestamp option #17994

Conversation

sheremet-va
Copy link
Member

Description

Removing injectInvalidationTimestamp since we don't use it anymore.

Copy link

stackblitz bot commented Sep 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sheremet-va sheremet-va changed the title refactor: remove "injectInvalidationTimestamp" option refactor: remove injectInvalidationTimestamp option Sep 2, 2024
@sheremet-va
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

@sheremet-va sheremet-va requested a review from bluwy September 2, 2024 12:50
@sheremet-va
Copy link
Member Author

Failing tests are the same as on v6 branch

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. By failing tests, do you mean the ecosystem-ci result, or the current PR CI fail? I've not seen the current CI fail before but maybe that's a flaky test.

@sheremet-va
Copy link
Member Author

LGTM. By failing tests, do you mean the ecosystem-ci result, or the current PR CI fail? I've not seen the current CI fail before but maybe that's a flaky test.

Both. The current CI error appears fairly often - I am not sure how to fix it, maybe you can help with your knowledge of HMR?

@sheremet-va sheremet-va merged commit 628c7a6 into vitejs:v6/environment-api Sep 2, 2024
8 of 9 checks passed
@sheremet-va sheremet-va deleted the v6/remove-invalidation-ts-option branch September 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants