-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backward compat for setting values in resolvedConfig hook #17947
fix: backward compat for setting values in resolvedConfig hook #17947
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/ecosystem-ci run vike |
📝 Ran ecosystem CI on
✅ |
The remaining failing test expects a full-reload to happen when a SSR module is edited even if that file is not imported from the client side. This is expected to fail since v6 and requires changes on the framework side, am I right? |
/ecosystem-ci run vike |
Modifying values in But in general, we should discuss what to do and document things up. One of the issues is that changes in I think even if the types were not completely forbidding changes, the docs were more clear:
We didn't respect this ourselves though. For example in the plugin legacy. The issue with environments config is that changes to the root values will not be reflected on the resolved environment options. My take here is that we should see why plugins need to do changes at |
📝 Ran ecosystem CI on
✅ |
@sheremet-va @hi-ogawa should we add an option to implement this? If there is a server only module, we could have a |
Making up |
build.emitAssets
in resolvedConfig hook
Description
Vike sets
build.emitAssets
in resolvedConfig hook and that was working in v5, but in v6 this is now ignored.I guess we don't support updating config values in resolvedConfig hook, but we don't explicitly document anywhere that we don't support that, too (the types are shallow readonly rather than deep readonly...).
I'm not sure if we should merge this PR, but this PR would make ecosystem-ci pass for Vike.