chore(ci): use step conditions to skip tests for doc changes #11700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
changed the title
sapphi-red
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
I agree with @dominikg. I think this one is more friendly to non-frequent contributors. (#11639 (comment))
Thanks for working on this. It was really hard than I thought. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #11639, #11548
@sapphi-red I reverted back to steps condition like @dominikg suggested to avoid manual conditions in a last step (#11639)
The issue here is that skipped test is a bit more hidden and not visible in checks overview.
For me both options are ok.