Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update extensions generated in library mode #11401

Merged
merged 2 commits into from
Dec 17, 2022
Merged

docs: update extensions generated in library mode #11401

merged 2 commits into from
Dec 17, 2022

Conversation

guillaumebriday
Copy link
Contributor

@guillaumebriday guillaumebriday commented Dec 17, 2022 •
edited
Loading

Description

Hey,

I think the extensions were wrong in the library mode documentation

Additional context

With "type": "module"
Screenshot 2022-12-16 at 19 05 23

Without "type": "module"
Screenshot 2022-12-16 at 19 06 09

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@guillaumebriday guillaumebriday changed the title Updating extensions generated in library mode docs: Updating extensions generated in library mode Dec 17, 2022
sapphi-red
sapphi-red reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When multiple entry points is used, Vite defaults the formats to be ['esm', 'cjs'] and umd won't be included.

@sapphi-red sapphi-red changed the title docs: Updating extensions generated in library mode docs: update extensions generated in library mode Dec 17, 2022
sapphi-red
sapphi-red approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red enabled auto-merge (squash) December 17, 2022 07:07
@sapphi-red sapphi-red merged commit 394148e into vitejs:main Dec 17, 2022
@jaysoo jaysoo mentioned this pull request Dec 21, 2022
Closed
9 tasks
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@guillaumebriday @futurGH
docs: update extensions generated in library mode (vitejs#11401)
a0f0e0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaumebriday @sapphi-red