Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relace antd menu jsx elements children with items prop #51

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: relace antd menu jsx elements children with items prop #51

merged 1 commit into from
Jun 13, 2022

Conversation

zheeeng
Copy link
Contributor

@zheeeng zheeeng commented Jun 13, 2022

see https://ant.design/components/menu/#Usage-upgrade-after-4.20.0

current console reports deprecation warning

@csr632 csr632 merged commit e1060bb into vitejs:main Jun 13, 2022
@csr632
Copy link
Member

csr632 commented Jun 13, 2022

Thanks!

@csr632
Copy link
Member

csr632 commented Jun 13, 2022 •
edited
Loading

The title prop of SubMenu and ItemGroup are no loger supported in the new items usage. Should replace title with label.

The english version of the antd doc is currently incorrect. It says SubMenuType supports title props but actually it doesn't.

Fixed by: 3b4d8ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zheeeng @csr632