Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): missing registerSW.js with injectManifest strategy #369

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

userquin
Copy link
Member

@userquin userquin commented Sep 6, 2022

When using injectManifest strategy with injectRegister auto or script, the registerSW.js not being served by the dev plugin.

closes #368

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for vite-plugin-pwa ready!

Name Link
🔨 Latest commit 8a78d23
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa/deploys/631780231c3c0a0008d8e97a
😎 Deploy Preview https://deploy-preview-369--vite-plugin-pwa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin changed the title fix(dev): 404 registerSW with injectManifest fix(dev): missing registerSW.js with injectManifest strategy Sep 6, 2022
@userquin userquin marked this pull request as draft September 6, 2022 14:05
@userquin
Copy link
Member Author

userquin commented Sep 6, 2022

Fixing some weird behavior restarting dev server...

@userquin userquin marked this pull request as ready for review September 6, 2022 17:15
@userquin userquin merged commit cd50e6e into main Sep 6, 2022
@userquin userquin deleted the fix/dev-register-sw-with-inject-manifest branch September 6, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev mode/InjectManifest: registerSW.js not found / no precaching inserted
1 participant