Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph2d] addCustomTime() is not working #472

Closed
WK6-work opened this issue May 12, 2020 · 1 comment · Fixed by #486
Closed

[Graph2d] addCustomTime() is not working #472

WK6-work opened this issue May 12, 2020 · 1 comment · Fixed by #486
Labels
bug Something isn't working released

Comments

@WK6-work
Copy link

example: https://codepen.io/wk6/pen/zYvaRKR

When addCustomeTime() called by Graph2d object, raise error.
graph2d-addmarker-error

In 7.1.3 vis-timeline, addCustomTime() works fine (but 7.2.0 or later not works).
https://codepen.io/wk6/pen/mdeKXjy
@yotamberk yotamberk added the bug Something isn't working label May 12, 2020
ryamaguchi0220 added a commit to ryamaguchi0220/vis-timeline that referenced this issue May 17, 2020
@ryamaguchi0220
fix: fix an access to an undefined object's property (visjs#472)
839f224
@ryamaguchi0220 ryamaguchi0220 mentioned this issue May 17, 2020
Merged
yotamberk pushed a commit that referenced this issue Jun 23, 2020
@ryamaguchi0220
Fix "Graph2d#addCustomTime doesn't work" (#472) (#486)
ff4a3c1 
* fix: fix an access to an undefined object's property (#472)

* fix: fix a bug that occures when dragging any marker

* feat: accept the snap option in Graph2d

* fix: use options.snap only when itemSet is undefined
@vis-bot
Copy link
Collaborator

vis-bot commented Sep 6, 2020

🎉 This issue has been resolved in version 7.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Graph2d#addCustomTime doesn't work" (#472) ryamaguchi0220/vis-timeline
3 participants
@yotamberk @WK6-work @vis-bot