Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): correct nodes.icon.face description #80

Merged
merged 1 commit into from
Sep 2, 2019
Merged

chore(docs): correct nodes.icon.face description #80

merged 1 commit into from
Sep 2, 2019

Conversation

Thomaash
Copy link
Member

@Thomaash Thomaash commented Aug 18, 2019

It used to imply that FontAwesome and Ionicons are the only faces that
can be used. In reality these can only be used if the user ships them
themselves and others can be used too if loaded on the page.

Resolves #59.

It used to imply that FontAwesome and Ionicons are the only faces that
can be used. In reality these can only be used if the user ships them
themselves and others can be used too if loaded on the page.

Addresses #59.
@Thomaash Thomaash requested a review from mojoaxel August 18, 2019 08:34
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Thomaash Thomaash merged commit 1a721e0 into visjs:master Sep 2, 2019
@Thomaash Thomaash deleted the issues/59 branch September 2, 2019 07:34
@vis-bot
Copy link
Collaborator

vis-bot commented Sep 3, 2019

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icon.fonts - choose other icon libraries
3 participants