Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node-shapes): add some node shapes tests #102

Merged
merged 6 commits into from
Aug 31, 2019
Merged

test(node-shapes): add some node shapes tests #102

merged 6 commits into from
Aug 31, 2019

Conversation

Thomaash
Copy link
Member

Before After
Passing 256 504
Statements 46.77% ( 3974/8497 ) 48.22% ( 4097/8497 )
Branches 41.27% ( 1695/4107 ) 42.66% ( 1752/4107 )
Functions 43.65% ( 481/1102 ) 47.19% ( 520/1102 )
Lines 47.23% ( 3814/8076 ) 48.75% ( 3937/8076 )

@Thomaash Thomaash requested a review from mojoaxel August 31, 2019 14:54
mojoaxel
mojoaxel approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Thomaash Thomaash merged commit 7e3d7d8 into visjs:master Aug 31, 2019
@Thomaash Thomaash deleted the node-shapes-test branch August 31, 2019 20:54
@Thomaash Thomaash assigned Thomaash and unassigned Thomaash Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojoaxel mojoaxel mojoaxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomaash @mojoaxel