'this' null testing patches for the release 8.0.x code line #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate numerous warnings caused by the deprecated presence of an 'll' qualifier in the "%p" format specifier. Syntax changes introduced by c++11 require that the string literals in a string concatentation (e.g, "abc" "def") be separated by a space (see the changes to VkRunTimes.h).
Format field lenght when parsing an 'unsigned int' should be '%u', not '%lu'.
GCC 6.3 (at least) no longer generates code that compares 'this' pointers to 'null'. While it's trivially easy to invoke a non-virtual member through using a 'null' pointer, the standard considers this to be 'undefined' behavior, so GCC 6.3 silently refuses to generate code for the test. While there may be clever ways to circumvent the compiler on the matter, the safest approach is to reorganize the code to give the compiler what it wants to see. This commit does that by relocated the required tests in the case of the implementation of 'VSymbolBinding::level ()' in the backend.
GCC 6.3 (at least) no longer generates code that compares 'this' pointers to 'null'. While it's trivially easy to invoke a non-virtual member through using a 'null' pointer, the standard considers this to be 'undefined' behavior, so GCC 6.3 silently refuses to generate code for the test. While there may be clever ways to circumvent the compiler on the matter, the safest approach is to reorganize the code to give the compiler what it wants to see. This commit does that by relocated the required tests in the case of the implementation of 'rtVECTOR_PMRDC::Append ()' in the backend.
Not only do recent c++ compilers (g++ 6.3) refuse to emit code to test if a 'this' pointer is null, in some cases, that refusal is not easily detectable by syntactic examination alone, as the changes submitted here attest.
MichaelJCaruso
changed the title
MichaelJCaruso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally intended to address issue #35, this pull request was closed and superseded by the more comprehensive changes of pull request #38 .