vxlan: Fix parseVxlanData for source port range #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary.Read() != nil check means error case, so the vxlan.Port{Low,High}
are never populated. Fix the check.
Signed-off-by: Daniel Borkmann <[email protected]>
|
Cc @aboch |
|
LGTM |
borkmann
added a commit
to cilium/cilium
that referenced
this pull request
Feb 21, 2025
Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062
borkmann
added a commit
to cilium/cilium
that referenced
this pull request
Feb 22, 2025
Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062
itspooya
pushed a commit
to itspooya/cilium
that referenced
this pull request
Feb 25, 2025
Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Feb 27, 2025
[ upstream commit 6ad6993 ] Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062 Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Feb 27, 2025
[ upstream commit 6ad6993 ] Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062 Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau
pushed a commit
to cilium/cilium
that referenced
this pull request
Feb 27, 2025
[ upstream commit 6ad6993 ] Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062 Signed-off-by: Nicolas Busseneau <[email protected]>
joamaki
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 5, 2025
[ upstream commit 6ad6993 ] Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062 Signed-off-by: Nicolas Busseneau <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 6, 2025
[ upstream commit 6ad6993 ] Import vxlan source port range fix. Signed-off-by: Daniel Borkmann <[email protected]> Link: vishvananda/netlink#1062 Signed-off-by: Nicolas Busseneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary.Read() != nil check means error case, so the vxlan.Port{Low,High} are never populated. Fix the check.