Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport flyTo Interpolation: add support for auto duration and other options. #866

Merged
merged 6 commits into from
Sep 6, 2019
Merged

Viewport flyTo Interpolation: add support for auto duration and other options. #866

merged 6 commits into from
Sep 6, 2019

Conversation

1chandu
Copy link
Contributor

@1chandu 1chandu commented Aug 17, 2019 •
edited
Loading

For #865

  • Bump viewport-mercator-poject version
  • Add support for auto duration
  • Add support for curve, speed, screenSpeed and maxDuration
  • Add docs and unit tests.

@1chandu 1chandu requested a review from Pessimistress August 17, 2019 01:14
Pessimistress
Pessimistress reviewed Aug 18, 2019
View reviewed changes
examples/viewport-animation/src/app.js Outdated Show resolved Hide resolved
src/utils/transition-manager.js Outdated Show resolved Hide resolved
@1chandu 1chandu force-pushed the FlyToAutoDuraiton branch from 609e3ae to 765ddcc Compare August 26, 2019 04:11
@1chandu 1chandu changed the title [NOT READY TO MERGE] FlyToViewport: add auto mode for duration Viewport flyTo Interpolation: add support for auto duration and other options. Sep 5, 2019
@coveralls
Copy link

coveralls commented Sep 5, 2019 •
edited
Loading

Coverage Status

Coverage increased (+11.8%) to 52.801% when pulling dd124a6 on FlyToAutoDuraiton into 1de9826 on master.

Pessimistress
Pessimistress reviewed Sep 5, 2019
View reviewed changes
docs/advanced/viewport-transition.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
docs/components/fly-to-interpolator.md Outdated Show resolved Hide resolved
src/utils/transition-manager.js Outdated Show resolved Hide resolved
@1chandu
Copy link
Contributor Author

1chandu commented Sep 5, 2019 •
edited
Loading

Addressed all comments, added unit tests for transitionManager changes, will merge after bumping viewport-mercator-project dep to 6.2.1.

@1chandu 1chandu mentioned this pull request Sep 6, 2019
Closed
@1chandu 1chandu merged commit 645100f into master Sep 6, 2019
@1chandu 1chandu deleted the FlyToAutoDuraiton branch September 6, 2019 05:31
xintongxia pushed a commit that referenced this pull request Sep 23, 2019
@1chandu
Viewport flyTo Interpolation: add support for auto duration and other…
eea2841 
… options. (#866)

* Viewport flyTo Interpoloation: add support for auto duration, curve, speed, screenSpeed and maxDuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1chandu @coveralls @Pessimistress