-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compressed popup when reaching right bound of map #823
Conversation
If I'm reading this correctly, it doesn't fix anything, just offers an option to fix it? |
I added a css style |
That is a breaking change and we can't publish it in a patch release.
|
src/components/popup.js
Outdated
translate(${-anchorPosition.x * 100}%, ${-anchorPosition.y * 100}%) | ||
translate(${left}px, ${top}px) | ||
`, | ||
maxWidth, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/popup.js
Outdated
@@ -40,6 +40,8 @@ const propTypes = Object.assign({}, BaseControl.propTypes, { | |||
offsetLeft: PropTypes.number, | |||
// Offset from the top | |||
offsetTop: PropTypes.number, | |||
// A number that sets the CSS property of the popup's maxWidth in pixels | |||
maxWidth: PropTypes.number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For #676