Fix map controller class extensibility #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcready
reviewed
Dec 6, 2018
src/utils/map-controller.js
Outdated
| @@ -204,14 +205,18 @@ export default class MapController { | |||
| } | |||
|
|
|||
| toggleEvents(eventNames: Array<string>, enabled: boolean) { | |||
| // Bind the method here instead of in the constructor, so that inherited classes | |||
| // do not have to do binding themselves | |||
There was a problem hiding this comment.
Not sure why you need to do this here. If you bind in the constructor as was the case before then any class that extends this one should call super() it its constructor which should trigger the binding.
There was a problem hiding this comment.
Hmm I seem to have confused this with a legacy autobinder issue we had. Will revert to the good old way of binding.
schnerd
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #669
handleEvent