Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in React 18 StrictMode (#1680) #2105

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix crash in React 18 StrictMode (#1680) #2105

merged 1 commit into from
Jan 24, 2023

Conversation

NameFILIP
Copy link
Contributor

Since v5.3.x is not working well (#2103), please accept the port of the fix for React 18 into the v5.2.x branch.

@NameFILIP
Copy link
Contributor Author

@Pessimistress would it be possible to merge and release this fix? 🙏

@NameFILIP
Copy link
Contributor Author

@Pessimistress it's the same commit that was merged into 5.3-releases, but 5.3 is less stable than 5.2, so asking to merge/release it for 5.2 as well.

@Pessimistress Pessimistress merged commit 53804ba into visgl:5.2-release Jan 24, 2023
@NameFILIP NameFILIP deleted the fix-v5.2-for-react-18 branch January 24, 2023 17:37
@NameFILIP
Copy link
Contributor Author

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NameFILIP @Pessimistress