Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default maxPitch to 60 #1720

Merged
merged 1 commit into from
Feb 6, 2022
Merged

fix: set default maxPitch to 60 #1720

merged 1 commit into from
Feb 6, 2022

Conversation

dreamorosi
Copy link
Contributor

  • Tests
  • npm run test must be successful. - DONE
  • New code should be covered by unit tests whenever possible. - N/A
  • Documentation
  • If public APIs are added/modified, update component documentation in docs/api-reference. - DONE
  • Breaking changes and deprecations must be added to docs/upgrade-guide.md. - N/A
  • Noteworthy new features should be added to docs/whats-new.md. - N/A
  • Description on GitHub
  • Link to relevant issue. - [Bug] default maxPitch of 85 breaks usage with [email protected] #1719
  • Label with a milestone (latest release or vNext). - DONE
  • If public APIs are added/modified, describe the intended behavior. - N/A
  • If visual/interaction is affected, consider attaching a screenshot/GIF. - N/A

Already updated the docs but not sure if the upgrade-guide.md and CHANGELOG.md should also be updated.

@dreamorosi
Copy link
Contributor Author

@Pessimistress thank you for reviewing & approving. Looking forward to use the patch 🎉

@Pessimistress Pessimistress merged commit 22d31d1 into visgl:master Feb 6, 2022
Pessimistress pushed a commit that referenced this pull request Feb 6, 2022
@dreamorosi dreamorosi deleted the fix/map/set_default_maxPitch_to_60 branch February 6, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants