Ensure fitBounds doesn't return NaN zoom value #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just out of curiosity, doesn't this result in zoom values being incoherent with the current state of the map? |
|
In what way would it be incoherent? The issue as far as I understand is that the function at https://github.com/mapbox/mapbox-gl-js/blob/master/js/geo/transform.js#L180 is being passed a negative scale, which when given to Math.log() will return NaN. My guess could be that this happens when dealing with negative latitude values perhaps? |
|
Yeah I was wondering if we could track down the exact cause of this behavior. This looks good to me, but let me add @abmai as reviewer too. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the NaN zoom value in issue #130.