Prevent attribution button from submitting forms #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Map is embedded within a form, clicking the attribution button submits is by default. By explicitly declaring it as a "button" and not "submit", we ensure that doesn't happen. For details see https://stackoverflow.com/a/10836076/6995854
Pessimistress
approved these changes
May 28, 2021
|
Thank you! |
Pessimistress
pushed a commit
that referenced
this pull request
Jun 4, 2021
Pessimistress
pushed a commit
that referenced
this pull request
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Map is embedded within a form, clicking the attribution button submits it by default.
By explicitly declaring it as a "button" and not "submit", we ensure that doesn't happen.
For details see https://stackoverflow.com/a/10836076/6995854