Remove extra props in GeolocateControl callback (#1480)

visgl · Jun 4, 2021 · 18a3d71 · 18a3d71
1 parent 1158d99
commit 18a3d71
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/src/components/geolocate-control.js b/src/components/geolocate-control.js
@@ -6,15 +6,11 @@ import {document} from '../utils/globals';
 import mapboxgl from '../utils/mapboxgl';
 
 import MapState from '../utils/map-state';
-import TransitionManager from '../utils/transition-manager';
+import {LINEAR_TRANSITION_PROPS} from '../utils/map-controller';
 import {isGeolocationSupported} from '../utils/geolocate-utils';
 
 import useMapControl, {mapControlDefaultProps, mapControlPropTypes} from './use-map-control';
 
-const LINEAR_TRANSITION_PROPS = Object.assign({}, TransitionManager.defaultProps, {
-  transitionDuration: 500
-});
-
 const noop = () => {};
 
 const propTypes = Object.assign({}, mapControlPropTypes, {

diff --git a/src/utils/transition-manager.d.ts b/src/utils/transition-manager.d.ts
@@ -5,8 +5,8 @@ export type ViewportProps = MapStateProps & {
   onTransitionStart: Function,
   onTransitionInterrupt: Function,
   onTransitionEnd: Function,
-  onViewportChange: Function,
-  onStateChange: Function
+  onViewportChange?: Function,
+  onStateChange?: Function
 };
 
 type TransitionState = {

diff --git a/src/utils/transition-manager.js b/src/utils/transition-manager.js
@@ -26,9 +26,7 @@ const DEFAULT_PROPS = {
   transitionInterruption: TRANSITION_EVENTS.BREAK,
   onTransitionStart: noop,
   onTransitionInterrupt: noop,
-  onTransitionEnd: noop,
-  onViewportChange: noop,
-  onStateChange: noop
+  onTransitionEnd: noop
 };
 
 export default class TransitionManager {