Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal tabs separating "Edit" and "Export" #68

Merged
merged 10 commits into from
Apr 11, 2021
Merged

Modal tabs separating "Edit" and "Export" #68

merged 10 commits into from
Apr 11, 2021

Conversation

RaymondDashWu
Copy link
Collaborator

@RaymondDashWu RaymondDashWu commented Feb 7, 2021 •
edited
Loading

Changelog

  • Export modal now has tabs for "Edit" and "Export"
  • Local styled-components.js to house all the styled.div used in export video modal codebase
  • Custom English localizations for "Edit", "Export"
  • Sections based off of:
    Untitled-1

@RaymondDashWu RaymondDashWu marked this pull request as draft February 7, 2021 03:28
@coveralls
Copy link

coveralls commented Feb 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 739285878

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 739254123: 0.0%
Covered Lines: 2
Relevant Lines: 2
💛 - Coveralls

@RaymondDashWu RaymondDashWu marked this pull request as ready for review February 7, 2021 07:12
@chrisgervang chrisgervang self-requested a review April 11, 2021 17:13
@chrisgervang chrisgervang self-assigned this Apr 11, 2021
@chrisgervang
Copy link
Collaborator

Some tasks to do in the next PR:

  • Split up resolution from aspect ratio
  • Move preview button to a "Play Icon" button under video
  • Move render button into "export" tab.
  • Make export tab the default tab.

@chrisgervang chrisgervang merged commit 213c172 into visgl:master Apr 11, 2021
@chrisgervang chrisgervang deleted the modal-divider-tabs branch April 11, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang chrisgervang approved these changes

Assignees

@chrisgervang chrisgervang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaymondDashWu @coveralls @chrisgervang