Remove kepler.gl recursive includes #51
Conversation
- Remove kepler.gl/ includes from react components entirely - Move ReactIntl integration to kepler-integration example as kepler.js provides its own already - Move react-intl dep to top level to avoid duplicated context instances
| <div style={{transition: 'margin 1s, height 1s', flex: 1}}> | ||
| <AutoSizer> | ||
| {({height, width}) => ( | ||
| <KeplerGl |
There was a problem hiding this comment.
Kepler would internally provide it's own IntlProvider. I guess these don't conflict (or kepler overrides the incoming object?)
There was a problem hiding this comment.
Yeah the inner one clobbers the outer one, so this should be fine. It's mainly there to make the modal work even though it's not embedded inside Kepler itself.
| @@ -70,7 +70,7 @@ class ExportVideoModal extends Component { | |||
| content: { | |||
| top: 'auto', | |||
| left: 'auto', | |||
| right: `calc(50% - ${DIMENSIONS.sidePanel.width / 2}px)`, | |||
| right: `calc(50% - ${SIDEPANEL_WIDTH / 2}px)`, | |||
There was a problem hiding this comment.
Ah, I see how this is necessary to import. If kepler's styled-components theme provides this we could pull it from there, but I suppose even that is unnecessary for this usage.
There was a problem hiding this comment.
Yeah I think export-video-modal.js is mainly useful for demonstration. It's not used with a custom modal rendering ExportVideoContainer directly. So it's not critical that this value can't be edited.
DIMENSIONSfromkepler.gl/constantswith the single constant we use. This is fixed in kepler.gl anyway.kepler-integrationexample to removekepler.gl/localizationdependency from component. This context is already provided inside kepler.gl.react-intldep to top level to avoid duplicated intl context instances in example