Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kepler.GL integration tweaks #49

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Kepler.GL integration tweaks #49

merged 1 commit into from
Dec 6, 2020

Conversation

unconed
Copy link
Contributor

@unconed unconed commented Dec 6, 2020 •
edited
Loading

  • Inject kepler.gl/components via KeplerUI react context
  • Add plugin-transform-runtime to add regeneratorRuntime into the build if it's missing (helps with kepler.gl integration)
  • Store resolution as WxH to make options forward compatible
  • Make modal title bar optional
  • Resolve deck/luma dependencies to 8.2 to match kepler
  • Allow export modal state to be persisted outside and rehydrated

@unconed
Kepler.GL integration tweaks
1262caa 
- Inject kepler.gl/components via KeplerUI react context
- Add plugin-transform-runtime to add regeneratorRuntime into the build if it's missing (helps with kepler.gl integration)
- Store resolution as WxH to make options forward compatible
- Make modal title bar optional
- Resolve deck/luma dependencies to 8.2 to match kepler
- Allow export modal state to be persisted outside and rehydrated via setStateAndNotify
- Bind setViewState
chrisgervang
chrisgervang approved these changes Dec 6, 2020
View reviewed changes
Copy link
Collaborator

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working out the kinks w.r.t the re-imports.

@chrisgervang chrisgervang reopened this Dec 6, 2020
@chrisgervang chrisgervang merged commit eef5f0a into visgl:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang chrisgervang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unconed @chrisgervang