Upgrade to deck 8.9, kepler v3.1, react-map-gl 7, and react 18 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
commented
Jan 23, 2025
examples/kepler/src/components/load-data-modal/sample-maps-tab.jsx
Outdated
Show resolved
Hide resolved
examples/kepler/src/components/load-data-modal/sample-data-viewer.jsx
Outdated
Show resolved
Hide resolved
Comment on lines
+90
to
+95
| (_, idx: number) => layers[idx].overlayType === 'deckgl' && layersToRender[layers[idx].id] | ||
| ) | ||
| .reduce((overlays: any, idx: number) => renderLayer(overlays, idx, map, viewState), []); // Slicing & reversing to create same layer order as Kepler | ||
| .reduce( | ||
| (overlays: any, _, idx: number) => renderLayer(overlays, idx, map, viewState, beforeId), | ||
| [] | ||
| ); // Slicing & reversing to create same layer order as Kepler |
There was a problem hiding this comment.
layersToRender is now a list of layer id's rather than layer indexes now. Can this be refactored to utilize this change?
Pull Request Test Coverage Report for Build 13066843883Details
💛 - Coveralls |
chrisgervang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, deck layers aren't rendering in the video exporter. The basemap renders as expected.
The PR mainly focuses on the kepler example. Upgrades in other examples and website to follow.