-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump deps #285
base: master
Are you sure you want to change the base?
chore: bump deps #285
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ coverage/ | |
.cache/ | ||
|
||
tsconfig.tsbuildinfo | ||
tsconfig.build.tsbuildinfo | ||
|
||
*/**/yarn.lock | ||
!website/yarn.lock | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,10 +4,10 @@ | |
/* global window */ | ||
|
||
import React, {Component, RefObject} from 'react'; | ||
import DeckGL, {DeckGLRef} from '@deck.gl/react/typed'; | ||
import DeckGL, {DeckGLRef} from '@deck.gl/react'; | ||
import {MapRef, StaticMap, StaticMapProps} from 'react-map-gl'; | ||
import {MapboxLayer} from '@deck.gl/mapbox/typed'; | ||
import type {DeckProps, MapViewState} from '@deck.gl/core/typed'; | ||
import {MapboxOverlay as MapboxLayer} from '@deck.gl/mapbox'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, this actually isn't a drop-in replacement and will require some changes to work. http://deck.gl/docs/upgrade-guide#deckglmapbox There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As a temporary fix I believe we can still import MapboxLayer with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather get this out of the way now. Im not getting any type errors, and all instances in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The API is different in MapboxOverlay. It creates a deck instance rather than getting passed an instance and that inversion would require a bit of refactoring There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I replaced the deck instance with the deck props in 03a2f0f I see that the link shows that MapboxLayer to MapboxOverlay shows |
||
import type {DeckProps, MapViewState} from '@deck.gl/core'; | ||
import isEqual from 'lodash.isequal'; | ||
|
||
import {deckStyle, DeckCanvas} from './styled-components'; | ||
|
@@ -163,13 +163,13 @@ export class ExportVideoPanelPreview extends Component< | |
|
||
// If there aren't any layers, combine map and deck with a fake layer. | ||
if (!keplerLayers.length) { | ||
map.addLayer(new MapboxLayer({id: '%%blank-layer', deck})); | ||
map.addLayer(new MapboxLayer({id: '%%blank-layer', ...deck})); | ||
mapboxLayerIds.push('%%blank-layer'); | ||
} | ||
|
||
for (let i = 0; i < keplerLayers.length; i++) { | ||
// Adds DeckGL layers to Mapbox so Mapbox can be the bottom layer. Removing this clips DeckGL layers | ||
map.addLayer(new MapboxLayer({id: keplerLayers[i].id, deck}), beforeId); | ||
map.addLayer(new MapboxLayer({id: keplerLayers[i].id, ...deck}), beforeId); | ||
mapboxLayerIds.push(keplerLayers[i].id); | ||
} | ||
|
||
|
@@ -207,7 +207,7 @@ export class ExportVideoPanelPreview extends Component< | |
controller={true} | ||
glOptions={{stencil: true}} | ||
onWebGLInitialized={gl => this.setState({glContext: gl})} | ||
onViewStateChange={({viewState: vs}) => setViewState(vs as MapViewState)} | ||
onViewStateChange={({viewState: vs}) => setViewState(vs)} | ||
{...(disableStaticMap ? {onAfterRender: this._onAfterRender} : {})} | ||
width={resolution[0]} | ||
height={resolution[1]} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luma 9.1 was released today and refines a lot of the APIs introduced in 9.0 https://luma.gl/docs/whats-new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting we set hubble 2.0 to target luma 9.1?