New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Correct zoom scale and bounds in kepler video export #136

Merged

chrisgervang merged 3 commits into master from chr/internal-map-state

Jul 6, 2021

Collaborator

chrisgervang commented Jul 1, 2021 •

edited

Loading

Modifies the export window's viewState to match the main map bounds using WebMercatorViewport.fitBounds.

TODO

Disconnect kepler mapState from animation viewState.
Scale export viewState to match bounds of main map
Layer zoom scale modified to match main map

References from kepler (using a different approach):

https://github.com/keplergl/kepler.gl/blob/master/src/utils/export-utils.js#L70-L91
https://github.com/keplergl/kepler.gl/blob/master/src/components/plot-container.js#L160-L172


          [enhancement] Correct zoom scale and map state bounds in kepler video…

169ec00

… export

coveralls commented Jul 1, 2021 •

edited

Loading

Pull Request Test Coverage Report for Build 1005365957

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 16.701%

Totals
Change from base Build 990848113:	0.0%
Covered Lines:	142
Relevant Lines:	667

💛 - Coveralls


          [enhancement] created scaleToVideoExport to match viewport bounds

4e05b6f

chrisgervang marked this pull request as ready for review

July 6, 2021 17:54


          Update export-video-panel-preview.js

chrisgervang merged commit 6029126 into master

chrisgervang deleted the chr/internal-map-state branch

October 14, 2021 19:46

chrisgervang added this to the 1.3 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet