Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Introducing animation classes #127

Merged
merged 8 commits into from
Jun 28, 2021
Merged

[enhancement] Introducing animation classes #127

merged 8 commits into from
Jun 28, 2021

Conversation

chrisgervang
Copy link
Collaborator

Added

  • Animation
  • DeckAnimation
  • KeplerAnimation

Todo

  • tests
  • docs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 980839160

  • 0 of 103 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 15.795%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/core/src/animations/animation.js 0 10 0.0%
modules/core/src/animations/deck-animation.js 0 41 0.0%
modules/core/src/animations/kepler-animation.js 0 52 0.0%
Totals Coverage Status
Change from base Build 980832412: -3.6%
Covered Lines: 142
Relevant Lines: 697
💛 - Coveralls

@chrisgervang chrisgervang merged commit 67915e8 into master Jun 28, 2021
@chrisgervang chrisgervang deleted the chr/animations branch June 28, 2021 23:55
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgervang @coveralls