Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] split DeckScene keyframes up between layers and camera. #121

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Jun 18, 2021

Changes

  • Instead of reserving camera key in keyframes object, give it a dedicated variable in DeckScene.
  • For DeckScene construction, initialKeyframes split into cameraKeyframes and layerKeyframes.
  • Added scene.setCameraKeyframes and scene.getCameraFrame

Renamed

  • scene.setKeyframes to scene.setLayerKeyframes
  • scene.getFrame to scene.getLayerFrame
  • scene.keyframes to scene.layerKeyframes. Added scene.cameraKeyframes
  • getKeyframes parameter renamed to getLayerKeyframes throughout DeckAdapter and examples.

@coveralls
Copy link

coveralls commented Jun 18, 2021

Pull Request Test Coverage Report for Build 950589590

  • 0 of 24 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 22.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/core/src/adapters/deck-adapter.js 0 6 0.0%
modules/core/src/scene/deck-scene.js 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
modules/core/src/scene/deck-scene.js 1 0%
Totals Coverage Status
Change from base Build 950454890: -0.3%
Covered Lines: 139
Relevant Lines: 537

💛 - Coveralls

@chrisgervang chrisgervang merged commit c88737a into master Jun 18, 2021
@chrisgervang chrisgervang deleted the chr/scene-keyframes branch June 18, 2021 17:44
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants