[chore] remove unnecessary readiness checks #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
commented
Jun 16, 2021
| @@ -12,9 +11,6 @@ const mapSlice = createSlice({ | |||
| reducers: { | |||
| updateViewState: (state, action) => | |||
| void (state.viewState = {...state.viewState, ...action.payload}) | |||
| }, | |||
| extraReducers: builder => { | |||
| builder.addCase('@@kepler.gl/REGISTER_ENTRY', state => void (state.ready = true)); | |||
There was a problem hiding this comment.
Moved out of mapSlice to appSlice, since mapSlice will soon be moved into the lib and we don't want to bring in unnecessary dependencies on kepler logic.
Pull Request Test Coverage Report for Build 944094325
💛 - Coveralls |
chrisgervang
commented
Jun 16, 2021
| this.deck = deck; | ||
| const props = { | ||
| onLoad: () => setReady(true), |
There was a problem hiding this comment.
Users can now use onLoad in their apps without hubble overriding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deck.onLoadin their apps without hubble overriding it.