Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Copy gif options before assignment. #113

Merged
merged 1 commit into from
Jun 15, 2021
Merged

[fix] Copy gif options before assignment. #113

merged 1 commit into from
Jun 15, 2021

Conversation

chrisgervang
Copy link
Collaborator

Encoder settings coming in are read-only objects, so copy before assigning defaults to fix error.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 941075456

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.534%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/core/src/encoders/video/gif-encoder.js 0 1 0.0%
Totals Coverage Status
Change from base Build 940170319: 0.0%
Covered Lines: 139
Relevant Lines: 555
💛 - Coveralls

@chrisgervang chrisgervang merged commit 640c550 into master Jun 15, 2021
@chrisgervang chrisgervang deleted the chr/gif-bug branch June 16, 2021 04:29
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgervang @coveralls