Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/typos #271

Merged
merged 16 commits into from
Jul 1, 2024
Merged

Fix/typos #271

merged 16 commits into from
Jul 1, 2024

Conversation

dzdidi
Copy link
Contributor

@dzdidi dzdidi commented Jul 1, 2024 •
edited
Loading

@dzdidi dzdidi requested a review from vincenzopalazzo as a code owner July 1, 2024 11:36
@dzdidi dzdidi force-pushed the fix/typos branch 2 times, most recently from 6aa1aba to 7163057 Compare July 1, 2024 12:13
@dzdidi dzdidi marked this pull request as draft July 1, 2024 14:07
dzdidi added 16 commits July 1, 2024 18:32
@dzdidi
common: fix typo in status failed for ln invoice
fb5b410 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
common: fix amount_msat typo in LnInvoiceInfo
6b4dad5 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
common: fix amount_msat typo in OpenChannel
fad6474 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
common: rename amount_satoshis to amount in Channel (for consistency)
33f9ab1 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
common: fix typo in docs for backend listen
42ec6ac 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
common: fix typo keys FIXME comment
4ae5633 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
bdk-wallet: fix typos in comments
92d021e 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
bitcoind: fix typos in comments
9384431 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
core-wallet: fix typos in comments and variable name
7d03590 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
jsonrpc: fix typo in comment
b014ba0 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
lampod: remove copypasted comment as missleading
493ab33 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
lampod: fix typo in fixme comment in handler
83538bb 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
lampod: fix typo in target cahnnel string for anchor_channel
65139ba 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
lampod: fix typo in fixme comment in jsonrpc
5ba7a42 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
lampod: fix typo in actions comments
af8cb96 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
lampod: fix typo in command comments
175e335 
Signed-off-by: dzdidi <[email protected]>
@dzdidi dzdidi marked this pull request as ready for review July 1, 2024 16:46
@dzdidi
Copy link
Contributor Author

dzdidi commented Jul 1, 2024

@vincenzopalazzo it does not look like my changes could have caused CI to fail, both failures seem to be caused by fail to install core lightning. I have not yet set up my local dev env to verify, sorry. If you do not mind I'll leave it up to your judgement

vincenzopalazzo
vincenzopalazzo approved these changes Jul 1, 2024
View reviewed changes
Copy link
Owner

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 175e335

Thanks for the clear commit history.

Regarding the CI there is nothing wrong, core lightning is not compatible with the offer spec and ldk is returning an error.

Regarding the install error I have the code to fix it in the next next (#227) branch but it needs some more love

@vincenzopalazzo vincenzopalazzo merged commit 7a99cf0 into vincenzopalazzo:main Jul 1, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzdidi @vincenzopalazzo