common: use adapter patter to customize the keys manager #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/vanilla-ldk
branch
from
bd3fc09 to
65d0d1e
Compare
lnprototest need to inject custom keys, and we fork ldk, but with time and discussion we finally have a solution that work with vanilla ldk. Suggested-by: Matt Corallo <@TheBlueMatt> Signed-off-by: Vincenzo Palazzo <[email protected]>
Finally we are able to remove the fork that we have of ldk. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/vanilla-ldk
branch
from
65d0d1e to
30da9a2
Compare
vincenzopalazzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lnprototest needs to inject custom keys, and we fork ldk, but
with time and discussion, we finally have a solution that works
with vanilla ldk.